Adds basic auth #96
Open
Adds basic auth #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 99.42% 99.43% +0.01%
==========================================
Files 2 2
Lines 345 354 +9
==========================================
+ Hits 343 352 +9
Misses 2 2
Continue to review full report at Codecov.
|
Open
|
very nice. :) thank you <3 Let's see when this gets a review |
dadkakdead
approved these changes
Oct 13, 2019
|
Hello Zeit 👋 Any update on this? Our team over here can be using this a lot :) Let me know if I can help in any way to get this merged! Thanks, |
|
fwiw, our team would love to have this work as well, so we can lock down internal deployments. |
|
This would be a really nice addition for dev environments. |
|
Any update on this progress? |
warren-bank
added a commit
to warren-bank/node-serve
that referenced
this pull request
Dec 22, 2021
based on:
* upstream PR 96
vercel/serve-handler#96
warren-bank
added a commit
to warren-bank/node-serve
that referenced
this pull request
Dec 22, 2021
based on:
* upstream PR 96
vercel/serve-handler#96
warren-bank
added a commit
to warren-bank/node-serve
that referenced
this pull request
Dec 22, 2021
based on:
* upstream PR 96
vercel/serve-handler#96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aiming to address #60, since there hasn't been much conversation around it yet. I tried to match the error responses as closely as possible to the surrounding code, and am working with a basic config setup of
"static": { "auth": [ "username", "password" ] }in the config file itself (I also am opening a PR to zeit/schemas to support this addition, vercel/schemas#54).Please let me know if additional changes are needed, I'd be happy to address any concerns. Or if this is a "will not fix" kind of issue, please let me know as well. I know for me and my team, though, this would make our lives a lot easier.
Note: I'm pretty sure I got most of the coverage, but again, just working off existing examples, let me know if more is needed. EDIT: found the issue, should be at 100% coverage now